angular plugin won't match errors from minified angular

[jrencz]

Minified angular minErr errors don't contain the description (see the very beginning of minified angular 1.6.5):

(function(F){'use strict';function O(a){return function(){var b=arguments[0],d;d="["+(a?a+":":"")+b+"] http://errors.angularjs.org/1.5.6/"+(a?a+"/":"")...

They only contain the identifier (e.g. [ngRepeat:dupes]) and then there's an URL with no message nor a new line character angular plugin depends on.

The quickest & dirtiest fix I found for that was to make the new line optional:

/^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.+?)\n(\S+)$/

/^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.+?)\n?(\S+)$/

but then URL is missing the first letter ('h') and it becomes the message

Better regexp is needed.

[benvinegar]

Hey @jrencz – any chance you could provide me with some sample values for both minified and un-minified Angular errors? I'd be glad to make this fix and put together some unit tests for verification.

[jrencz]

I'm using Angular 1.4.3 inside Ionic 1.2

Error message when I'm using ionic.bundle.js (stringified JSON object reduced to one key):

[ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: element in elements | orderBy: 'createdAt' track by element.id, Duplicate key: 25, Duplicate value: {"id":"booking-40"}
http://errors.angularjs.org/1.4.3/ngRepeat/dupes?p0=element%20in%20elements…00%3A00%22%2C%22ends_at%22%3A%222016-06-09T23%3A59%3A59%2B00%3A00%22%7D%7D

when I'm using ionic.bundle.min.js:

Error: [ngRepeat:dupes] http://errors.angularjs.org/1.4.3/ngRepeat/dupes?p0=element%20in%20elements…00%3A00%22%2C%22ends_at%22%3A%222016-06-09T23%3A59%3A59%2B00%3A00%22%7D%7D

I tweaked the expression a bit so it matches both:

/^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] ([\s\S]*)((?:https?:\/\/errors\.angularjs\.org[\s\S]*))$/

It matches both cases correctly (i.e. type, value, doc url or type, empty string and doc url).
but it can probably be optimized

Note that http://errors.angularjs.org/1.4.3/ngRepeat/dupes?p0=element%20in%20elements…00%3A00%22%2C%22ends_at%22%3A%222016-06-09T23%3A59%3A59%2B00%3A00%22%7D%7D does not bring any meaningful information when accessed. Am I wrong or does Angular shoot itself in the foot by collapsing the url as well?

[jrencz]

There's also the $injector:modulerr which has recurring message:

[$injector:modulerr] Failed to instantiate module A due to:
Error: [$injector:modulerr] Failed to instantiate module B due to:
Error: [$injector:modulerr] Failed to instantiate module C due to:
Error: [$injector:nomod] Module 'C' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

which will still be problematic and IMO it should be handled differently.

[jrencz]

@benvinegar any progress here?

[benvinegar]

@jrencz Yes. #667.

There's also the $injector:modulerr which has recurring message:

I decided to skip this for now. Is it common to get runtime module loading errors in production?

[jrencz]

I decided to skip this for now. Is it common to get runtime module loading errors in production?

By all means not. This error is only expected in development.

[benvinegar]

This error is only expected in development.

That's kind of what I expected, but I thought I'd check. (But at the same time people often test Sentry on development code, so this is probably something we'd want to address anyways in the future.)

[jrencz]

It may also appear in some kind of staging environments if code is loaded lazily some way. angular1 does not allow lazy module loading but people tend to get creative

[benvinegar]

Either way, we'll close this and open up that behavior as a new ticket.