Skip to content

fix(nextjs): Pass request in sampling context of data fetchers wrapper transaction #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Sep 21, 2022

This is a second attempt at #5730, which I incautiously merged into another branch rather than into master. From that PR description:

This adds the request to the sampling context passed to the startTransaction call in the data fetchers wrapper in nextjs, to bring it in line with the startTransaction calls elsewhere in the SDK.

@lobsterkatie lobsterkatie changed the title Kmclb nextjs add sampling context in data fetcher wapper fix(nextjs): Pass request in sampling context of data fetchers wrapper transaction Sep 21, 2022
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper branch from ab6d376 to 050c525 Compare September 21, 2022 14:01
@lobsterkatie lobsterkatie marked this pull request as ready for review September 21, 2022 14:04
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.47 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.16 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.06 KB (-0.03% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.08 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.85 KB (0%)
@sentry/browser - Webpack (minified) 64.49 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.88 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.73 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.93 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.33 KB (-0.01% 🔽)

@lobsterkatie lobsterkatie merged commit 4753836 into master Sep 21, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper branch September 21, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants