fix(nextjs): Pass request in sampling context of data fetchers wrapper transaction #5730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok |
lobsterkatie
force-pushed
the
kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper
branch
from
b0e42b9 to
0093c9c
Compare
lobsterkatie
force-pushed
the
kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper
branch
from
0093c9c to
ab6d376
Compare
lobsterkatie
changed the base branch from
master
to
kmclb-nextjs-use-requestdata-integration-for-errors
AbhiPrasad
approved these changes
Sep 21, 2022
lobsterkatie
merged commit a780472
into
kmclb-nextjs-use-requestdata-integration-for-errors
lobsterkatie
deleted the
kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper
branch
lobsterkatie
restored the
kmclb-nextjs-add-sampling-context-in-data-fetcher-wapper
branch
|
Dammit. Merged into the wrong branch. 🤦🏻♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the request to the sampling context passed to the
startTransactioncall in the data fetchers wrapper in nextjs, to bring it in line with thestartTransactioncalls elsewhere in the SDK.