wrap jquery's deferred[ resolveWith | rejectWith | notifyWith ]

[matghaleb]

New implementation of previous PR #266

[mattrobenolt]

Wouldn't we want to check that $.Deferred is not undefined first? Or does it not matter?

[benvinegar]

Worst case is that it introduces (a broken) $.Deferred when it wasn't there before. But yeah, I'd probably leave it if it's not defined.

Aside, $.Deferred was introduced in jQuery 1.5 in 2011.

[mattrobenolt]

@matghaleb Is it possible to supply a test case for this? Even if it's a jsfiddle or something functional.

This is a very highly used plugin and I'd be afraid of breaking it without actually testing it.

[matghaleb]

@mattrobenolt, I just updated my pull request fixing some bugs and supporting more jQuery versions.

you can test the new plugin from this jsfiddle: (working fine from jQuery 1.6.4 to 2.1.0)
http://jsfiddle.net/6u6nrmq0/

and compare the results with the current version:
http://jsfiddle.net/n6jgbztz/

[skovhus]

Look interesting... But some unit test could be awesome. 👍

[dcramer]

No isolation, but basic functional test for one func in fa86837

[dcramer]

Not entirely sure of how best to improve the tests.

Ideally we'd:

• get the $.ajax tests in
• ensure that deferred behaves the same as before (not just that it captures errors)