jQuery Plugin: Wrap jqXHR promise callbacks #266
Conversation
| // call _oldAjax and store jqXHR | ||
| jqXHR = _oldAjax.call(this, url, options); | ||
| // wrap jqXHR promise handlers | ||
| wrapObjectKeys(jqXHR, ['done', 'success', 'fail', 'error', 'always', 'then', 'complete']); |
There was a problem hiding this comment.
Can we move this part to outside the try...catch ?
I don't want to swallow an exception caused by wrapObjectKeys or something. Just bad practice since we only want to capture the exception from _oldAjax.call
|
@matghaleb I know basically nothing about promises in jQuery, but is there a lower level primitive that we can patch here instead that gives us more coverage over other events too possibly? |
|
Like, if we can say, automatically patch all promises, no matter if they're from an XHR request or something else. |
|
We should definitely be able to patch this stuff: https://github.com/jquery/jquery/blob/master/src/deferred.js |
|
We should be able to patch |
|
@mattrobenolt Thx for your feedbacks. I'll look more carefully at |
|
I just wrote a new PR #268 patching |
Since jQuery 1.5, jQuery.ajax implements the Promise interface and that's why the jqXHR.done(), jqXHR.fail(), jqXHR.always(), jqXHR.then() callbacks need to be wrapped too.
Note that the jqXHR.success(), jqXHR.error(), and jqXHR.complete() callbacks are deprecated as of jQuery 1.8 but are still exposed.