Repository navigation
test(e2e): Add Mastra Jev classifier test to node-mastra - #25115
Merged
andreiborza merged 3 commits intoOct 8, 2026
Merged
Conversation
andreiborza
added this pull request to stack #25116
October 7, 2026 08:16
andreiborza
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d3c4b79. Configure here.
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
October 7, 2026 08:58
andreiborza
force-pushed
the
ab/mastra-classifier-e2e
branch
2 times, most recently
from
October 7, 2026 09:40
3b82bae to
8fd928f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nicohrubec
approved these changes
Oct 7, 2026
| @@ -0,0 +1,10 @@ | |||
| import { createOpenRouter } from '@openrouter/ai-sdk-provider'; | |||
Member
There was a problem hiding this comment.
l: I think other scenarios also use openrouter. could this be used there as well?
Member
Author
There was a problem hiding this comment.
They do now in this pr, I moved the weather agent to the same shared helper.
Member
There was a problem hiding this comment.
I meant for instance node-eve has the same logic and that could also be replaced
Member
Author
There was a problem hiding this comment.
Right, I'll do that in follow-up tasks as it doesn't quite fit into here.
| const APP = 'node-mastra'; | ||
| const TICKET = 'My checkout page shows a blank screen after I click Pay.'; | ||
|
|
||
| const attrValue = (span: SerializedStreamedSpan, key: string): unknown => span.attributes?.[key]?.value; |
Member
There was a problem hiding this comment.
nit but this seems like an unnecessary indirection 😅
chargome
approved these changes
Oct 7, 2026
JPeer264
approved these changes
Oct 7, 2026
andreiborza
force-pushed
the
ab/mastra-classifier-e2e
branch
from
October 8, 2026 11:45
f7c126f to
52100dc
Compare
andreiborza
force-pushed
the
ab/mastra-classifier-e2e
branch
from
October 8, 2026 12:16
52100dc to
fe21450
Compare
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a node-mastra e2e test that runs a real Jev evaluation through a Mastra
Classifier(via OpenRouter) and checks thegen_ai.evaluatespan.Why
Covers the classifier instrumentation from #25044 against the real provider, not only a mock model.