Inline span attribute access in classifier test

Author: andreiborza

dev-packages/e2e-tests/test-applications/node-mastra/tests/classifier.test.ts

@@ -15,11 +15,9 @@ import { collectStreamedSpans, getSpanOp, SerializedStreamedSpan } from '@sentry
 const APP = 'node-mastra';
 const TICKET = 'My checkout page shows a blank screen after I click Pay.';
 
-const attrValue = (span: SerializedStreamedSpan, key: string): unknown => span.attributes?.[key]?.value;
-
 const isEvaluateSpan = (span: SerializedStreamedSpan): boolean => getSpanOp(span) === GEN_AI_EVALUATE;
 const isClassifyServerSpan = (span: SerializedStreamedSpan): boolean =>
-  getSpanOp(span) === HTTP_SERVER && String(attrValue(span, URL_FULL) ?? '').includes('/classify');
+  getSpanOp(span) === HTTP_SERVER && String(span.attributes?.[URL_FULL]?.value ?? '').includes('/classify');
 
 test('captures a Mastra classifier (Jev) evaluation as a gen_ai.evaluate span', async ({ baseURL }) => {
   const spansPromise = collectStreamedSpans(
@@ -41,17 +39,17 @@ test('captures a Mastra classifier (Jev) evaluation as a gen_ai.evaluate span',
   // Only the Mastra exporter reports the evaluation: `Classifier` calls `doEvaluate()` directly, so the
   // Vercel AI integration does not see it.
   const evaluateSpans = spans.filter(isEvaluateSpan);
-  expect(evaluateSpans.map(span => ({ name: span.name, origin: attrValue(span, SENTRY_ORIGIN) }))).toEqual([
+  expect(evaluateSpans.map(span => ({ name: span.name, origin: span.attributes?.[SENTRY_ORIGIN]?.value }))).toEqual([
     { name: 'evaluate typesafe/jev-1.13', origin: 'auto.ai.mastra' },
   ]);
 
   const evaluateSpan = evaluateSpans[0]!;
   expect(evaluateSpan.parent_span_id).toBe(serverSpan.span_id);
-  expect(attrValue(evaluateSpan, GEN_AI_OPERATION_NAME)).toBe('evaluate');
-  expect(attrValue(evaluateSpan, GEN_AI_REQUEST_MODEL)).toBe('typesafe/jev-1.13');
-  expect(attrValue(evaluateSpan, GEN_AI_PROVIDER_NAME)).toBe('openrouter');
-  expect(attrValue(evaluateSpan, GEN_AI_USAGE_INPUT_TOKENS)).toBeGreaterThan(0);
-  expect(JSON.parse(String(attrValue(evaluateSpan, GEN_AI_INPUT_MESSAGES)))).toEqual([
+  expect(evaluateSpan.attributes?.[GEN_AI_OPERATION_NAME]?.value).toBe('evaluate');
+  expect(evaluateSpan.attributes?.[GEN_AI_REQUEST_MODEL]?.value).toBe('typesafe/jev-1.13');
+  expect(evaluateSpan.attributes?.[GEN_AI_PROVIDER_NAME]?.value).toBe('openrouter');
+  expect(evaluateSpan.attributes?.[GEN_AI_USAGE_INPUT_TOKENS]?.value).toBeGreaterThan(0);
+  expect(JSON.parse(String(evaluateSpan.attributes?.[GEN_AI_INPUT_MESSAGES]?.value))).toEqual([
     {
       type: 'evaluation',
       state: { ticket: TICKET },
@@ -61,7 +59,7 @@ test('captures a Mastra classifier (Jev) evaluation as a gen_ai.evaluate span',
     },
   ]);
   // The probability comes from the live model, so only its shape is stable.
-  expect(JSON.parse(String(attrValue(evaluateSpan, GEN_AI_OUTPUT_MESSAGES)))).toEqual([
+  expect(JSON.parse(String(evaluateSpan.attributes?.[GEN_AI_OUTPUT_MESSAGES]?.value))).toEqual([
     { type: 'evaluation', answers: { is_bug: { type: 'boolean', probability: expect.any(Number) } } },
   ]);
 });