Conversation
…#16390) Adding e2e tests for SPA mode for react router framework. It was confirmed that navigation and client pageload instrumentations work. closes getsentry/sentry-docs#13856
[Gitflow] Merge master into develop
…iErrorsIntegration` (#16412) This patch adds an option to fix a very unfortunate, effective double invocation of callbacks on objects inheriting from our `EventTarget.addEventListener` instrumentation (to be found in `browserApiErrorsIntegration`. Affected users can switch on the new option and doing so will make our instrumentation of `addEventListener` also call `removeEventListener` on for the original callback. Applied to the example above, it will essentially restore the idempotency of `addEventListener`. At the same time, it feels very risky to do this so for the time being, we'll keep this (and document it as) opt-in. Usage: ```js Sentry.init({ // ... integrations: [ Sentry.browserApiErrorsIntegration({ unregisterOriginalCallbacks: true, }), ], }); ``` Docs PR: getsentry/sentry-docs#13859 fixes #16398
Co-authored-by: Onur Temizkan <onur@narval.co.uk>
6deb18d to
d8f3f8f
Compare
AbhiPrasad
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's get this out soon to unblock users wanting to upgrade to Angular 20.
Draft in case we want to add more to this release