test(react-router): Add e2e tests for react router framework SPA mode #16390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RulaKhaled
changed the title
RulaKhaled
changed the title
chargome
reviewed
May 28, 2025
dev-packages/e2e-tests/test-applications/react-router-7-framework-spa/app/root.tsx
Outdated
Show resolved
Hide resolved
| <button | ||
| id="throw-on-click" | ||
| onClick={() => { | ||
| throw new Error('¡Madre mía!'); |
| ], | ||
| }, | ||
| // todo: should be '/errors/client/:client-param' | ||
| transaction: '/errors/client/churros', |
There was a problem hiding this comment.
We don't have these parameterized? 🤔
There was a problem hiding this comment.
Apparently not for errors, this isn't a special case for SPA though check out https://github.com/getsentry/sentry-javascript/blob/develop/dev-packages/e2e-tests/test-applications/react-router-7-framework/tests/errors/errors.client.test.ts#L81. Maybe there's an issue for this somewhere?
chargome
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding e2e tests for SPA mode for react router framework. It was confirmed that navigation and client pageload instrumentations work.
closes getsentry/sentry-docs#13856