-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(sveltekit): Add wrapServerRouteWithSentry
wrapper
#13247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
andreiborza
approved these changes
Aug 8, 2024
size-limit report 📦
|
Lms24
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Aug 9, 2024
…0990) adds documentation for the new `wrapServerRouteWithSentry` function we added in getsentry/sentry-javascript#13247. --------- Co-authored-by: Nicolas Hrubec <nicolas.hrubec@outlook.com>
2 tasks
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick side-quest: This PR adds a wrapper for SvelteKit server routes. The reason is that some errors (e.g. sveltekit
error()
calls) are not caught within server (API) routes, as reported in #13224 because in contrast toload
function we don't directly try/catch the function invokation.For now, users will have to add this wrapper manually. At a later time we can think about auto instrumentation, similarly to
load
functions but for now this will remain manual.This wrapper:
Error
-like errorserror()
errors if the status is >=500Usage example:
Resulting span:
Related changes:
sendErrorToSentry
as it's universally used in server-side wrapperscloses #13224
docs PR: getsentry/sentry-docs#10990