-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(sveltekit): Document new wrapServerRouteWithSentry
wrapper
#10990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sveltekit): Document new wrapServerRouteWithSentry
wrapper
#10990
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
||
<Note> | ||
|
||
Available since version `7.91.0` | ||
Available since `8.24.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder for myself to double check that this is the actual version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it's 8.25.0
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
|
||
<Note> | ||
|
||
Available since version `7.91.0` | ||
Available since `8.24.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it's 8.25.0
``` | ||
|
||
##### Disable Client-side `fetch` Proxy Script | ||
```typescript {filename:+server.ts} {1,3} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this duplicated for ts and js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because you can use JS and TS simultaneously in SvelteKit. But most of these snippets have no TS-specific syntax, so it might be better to switch to a shared filename.(js|ts)
snippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm realizing, we're a bit inconsistent with the languages and even diverge a bit. I'll dedupe the snippets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened an additional PR because I streamlined some other things while removing the TS stuff: #11038
Co-authored-by: Nicolas Hrubec <nicolas.hrubec@outlook.com>
c603942
to
e76bb5f
Compare
DESCRIBE YOUR PR
This PR adds documentation for the new
wrapServerRouteWithSentry
function we added in getsentry/sentry-javascript#13247. While adding this, I slightly restructured the Manual Setup page of the SvelteKit guide to now have "Automatic Instrumentation" and "Manual Instrumentation" headings on the same level.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: