Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(remix): Run both otel and legacy integration tests on CI #12983

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Realised this was missing while looking at #12949

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid using run-s here? other than this, good call! But I wonder, should this not also be covered by the E2E tests that we have? 🤔

packages/remix/package.json Outdated Show resolved Hide resolved
packages/remix/package.json Outdated Show resolved Hide resolved
@onurtemizkan onurtemizkan force-pushed the onur/remix-otel-ci-integration-tests branch from 46a5ce6 to 82c93f5 Compare July 22, 2024 11:48
@onurtemizkan
Copy link
Collaborator Author

@mydea - I added new cases to the E2E tests 👍

@onurtemizkan onurtemizkan force-pushed the onur/remix-otel-ci-integration-tests branch from 82c93f5 to a3ae2c4 Compare July 22, 2024 12:32
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 24, 2024 15:29
@onurtemizkan onurtemizkan force-pushed the onur/remix-otel-ci-integration-tests branch from a3ae2c4 to 0eebf3c Compare July 24, 2024 21:31
@AbhiPrasad AbhiPrasad merged commit 36f62bb into develop Jul 24, 2024
101 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-otel-ci-integration-tests branch July 24, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants