Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix): Remove unnecessary http instrumentation override #12949

Closed
wants to merge 1 commit into from
Closed

feat(remix): Remove unnecessary http instrumentation override #12949

wants to merge 1 commit into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 17, 2024

I just kind of want to see what happens...

@mydea mydea self-assigned this Jul 17, 2024
@mydea mydea requested a review from onurtemizkan July 17, 2024 11:13
@mydea
Copy link
Member Author

mydea commented Jul 17, 2024

@onurtemizkan do you remember, was there a problem with this? It seems that all tests are passing, but maybe we are not covering something well 😅

@onurtemizkan
Copy link
Collaborator

@mydea -- There was definitely a need to do that in the first implementation, and I remember that the tests were failing 🤔 Let me check locally.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.47 KB (0%)
@sentry/browser (incl. Tracing) 34.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.65 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.71 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.33 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.17 KB (0%)
@sentry/browser (incl. metrics) 26.77 KB (0%)
@sentry/browser (incl. Feedback) 39.42 KB (0%)
@sentry/browser (incl. sendFeedback) 27.09 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.75 KB (0%)
@sentry/react 25.24 KB (0%)
@sentry/react (incl. Tracing) 37.25 KB (0%)
@sentry/vue 26.62 KB (0%)
@sentry/vue (incl. Tracing) 36.1 KB (0%)
@sentry/svelte 22.61 KB (0%)
CDN Bundle 23.69 KB (0%)
CDN Bundle (incl. Tracing) 35.94 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.62 KB (0%)
CDN Bundle - uncompressed 69.52 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.45 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.19 KB (0%)
@sentry/nextjs (client) 37.11 KB (0%)
@sentry/sveltekit (client) 34.82 KB (0%)
@sentry/node 115.47 KB (0%)
@sentry/node - without tracing 89.86 KB (+0.01% 🔺)
@sentry/aws-serverless 99.3 KB (+0.01% 🔺)

onurtemizkan
onurtemizkan reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@onurtemizkan onurtemizkan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mydea - Looks like the integration tests on CI did not include the new OTEL-instrumented usage. I'll open a separate PR adding that.

Removing the HTTP instrumentation breaks the OTEL-instrumented tests - Run

@onurtemizkan onurtemizkan mentioned this pull request Jul 18, 2024
Merged
@mydea mydea closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurtemizkan onurtemizkan onurtemizkan left review comments

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @onurtemizkan