Skip to content

feat(feedback): New feedback button design #11641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2024
Merged

feat(feedback): New feedback button design #11641

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04ce7f2
button designs
c298lee Apr 16, 2024
8a614f0
lint
c298lee Apr 16, 2024
ead7ae7
new config
c298lee Apr 17, 2024
0a2b205
Revert "new config"
c298lee Apr 19, 2024
70e56cc
PR comments
c298lee Apr 19, 2024
b9d4aa4
Merge branch 'develop' into cl/feedback-button
c298lee Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/feedback/src/constants/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const LIGHT_THEME = {
backgroundHover: '#f6f6f7',
foreground: '#2b2233',
border: '1.5px solid rgba(41, 35, 47, 0.13)',
borderRadius: '12px',
borderRadius: '99px',
boxShadow: '0px 4px 24px 0px rgba(43, 34, 51, 0.12)',

success: '#268d75',
Expand Down
10 changes: 8 additions & 2 deletions packages/feedback/src/core/components/Actor.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function createActorStyles(): HTMLStyleElement {
top: var(--top);
z-index: var(--z-index);

line-height: 25px;
line-height: 16px;

display: flex;
align-items: center;
Expand All @@ -26,7 +26,7 @@ export function createActorStyles(): HTMLStyleElement {
font-family: inherit;
font-size: var(--font-size);
font-weight: 600;
padding: 12px 16px;
padding: 16px;
text-decoration: none;
z-index: 9000;

Expand Down Expand Up @@ -56,6 +56,12 @@ export function createActorStyles(): HTMLStyleElement {
.widget__actor__text {
}

@media (max-width: 600px) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for another number for viewport boundary is welcome!

Copy link
Member

@michellewzhang michellewzhang Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like most mobile devices have widths < 600
only ipads have viewport widths of 700+ which means ipad users would see the big button, which is probably fine!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.icwebdesign.co.uk/common-viewport-sizes looking at this very non-sus website

.widget__actor__text {
display: none;
}
}

.feedback-icon path {
fill: var(--foreground);
}
Expand Down
Loading