feat(feedback): New feedback button design #11641
Conversation
| @@ -56,6 +56,12 @@ export function createActorStyles(): HTMLStyleElement { | |||
| .widget__actor__text { | |||
| } | |||
|
|
|||
| @media (max-width: 600px) { | |||
There was a problem hiding this comment.
Suggestions for another number for viewport boundary is welcome!
There was a problem hiding this comment.
looks like most mobile devices have widths < 600
only ipads have viewport widths of 700+ which means ipad users would see the big button, which is probably fine!
There was a problem hiding this comment.
https://www.icwebdesign.co.uk/common-viewport-sizes looking at this very non-sus website
size-limit report 📦
|
|
This seems fine to me, but one alternative approach that would maybe safe some bytes (and avoid adding another option) would be to just hide the text via CSS on small viewports...? |
I'd agree with this, keeps config simpler - seems like a rare case you would want slightly shorter text on mobile. Showing only icon feels like a good default for small viewports. |
This reverts commit ead7ae7.
Updates feedback actor button with new designs. The button doesn't show the label on small viewports now.
Window over 600px:
Window under 600px:
Fixes #11541 and https://github.com/getsentry/team-replay/issues/413