feat: Add @sentry-internal/browser-utils #11381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
s1gr1d,
a team and
mydea
and removed request for
a team
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-browser-utils
branch
from
5c0b74c to
c6128f1
Compare
AbhiPrasad
force-pushed
the
abhi-browser-utils
branch
from
c6128f1 to
4cb9912
Compare
AbhiPrasad
force-pushed
the
abhi-browser-utils
branch
from
e10f027 to
6058f06
Compare
Lms24
approved these changes
Apr 5, 2024
AbhiPrasad
added a commit
that referenced
this pull request
Apr 8, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This PR creates a `browser-utils` package that contains browser specific utils that can be shared between the browser, replay, and feedback packages. Eventually we will move `browserTracingIntegration` outside of this package, but the instrumentation handlers will remain here. We will also move the browser related utils in `@sentry/utils` to this package. Given this removes `@sentry-internal/tracing` entirely, it is a part of getsentry#9885 ref getsentry#9832
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…#11451) ref getsentry#9832 Building off getsentry#11381, this moves browser related utils into the browser utils package. Next step is to move `browserTracingIntegration` into browser!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a
browser-utilspackage that contains browser specific utils that can be shared between the browser, replay, and feedback packages.Eventually we will move
browserTracingIntegrationoutside of this package, but the instrumentation handlers will remain here. We will also move the browser related utils in@sentry/utilsto this package.Given this removes
@sentry-internal/tracingentirely, it is a part of #9885ref #9832