ref(browser): Move utils to @sentry-internal/browser-utils #11451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson and
Lms24
and removed request for
a team
AbhiPrasad
commented
Apr 5, 2024
| XhrBreadcrumbData, | ||
| XhrBreadcrumbHint, | ||
| } from '@sentry/types/build/types/breadcrumb'; |
There was a problem hiding this comment.
While working on this I noticed we were incorrectly importing from @sentry/types at times. I fixed this wherever possible.
AbhiPrasad
force-pushed
the
abhi-move-browser-utils
branch
from
f0ec060 to
6b9cb77
Compare
size-limit report 📦
|
Lms24
approved these changes
Apr 8, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…#11451) ref getsentry#9832 Building off getsentry#11381, this moves browser related utils into the browser utils package. Next step is to move `browserTracingIntegration` into browser!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9832
Building off #11381, this moves browser related utils into the browser utils package.
Next step is to move
browserTracingIntegrationinto browser!