feat(core): Filter out noisy GoogleTag error by default#11208
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-filter-googletag-errors
branch
from
a1a8698 to
47f2f6c
Compare
Lms24
requested review from
a team,
AbhiPrasad and
HazAT
and removed request for
a team
Lms24
force-pushed
the
lms/feat-filter-googletag-errors
branch
from
47f2f6c to
64dc42f
Compare
lforst
approved these changes
Mar 20, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
) We received reports about this error ``` TypeError: Cannot redefine property: googletag ``` being thrown and reported to Sentry. It's a noisy error where we strongly suspect that browser extensions interfere with our users' apps. In an effort to quickly reduce noise, this patch adds the error message to our SDK `inboundFilters` integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received reports about this error
being thrown and reported to Sentry. It's a noisy error where we strongly suspect that browser extensions interfere with our users' apps. In an effort to quickly reduce noise, this PR adds the error message to our SDK
inboundFiltersintegration.Side-note: In my opinion we cannot continue adding such filters SDK-side long-term. For the moment we have to because other SDK areas like Replay or spans would incorrectly change their state on an error we first send to Sentry but later on drop in Relay. However, long-term, I strongly think connecting (and sampling) has to happen server side. Otherwise our SDK grows and bundlesize inevitably increases.