Add element binding extensibility

[aritchie]

Implements #3996

• Extension point will help for Mobile Vitals #3181 features.
• Adds support for image buttons mentioned in Enhanced Breadcrumb Logging for .NET MAUI's ImageButton #3803
• All code is covered by existing unit tests.

[jamescrosswell]

LGTM.

About the only thing I couldn't see (maybe I missed it) is where MauiButtonEventsBinder gets tested. I see tests for MauiImageButtonEventsBinder.

If these are missing, would be good to add them before merge.

[aritchie]

ImageButton tests are under MauiEventsBinder.ImageButton.

[jamescrosswell]

ImageButton tests are under MauiEventsBinder.ImageButton.

Yeah I saw those. I didn't see any equivalent for MauiButtonEventsBinder though...

[aritchie]

They already existed. I only moved button code out of the original mauieventbinder into its own element binder

[jamescrosswell]

They already existed. I only moved button code out of the original mauieventbinder into its own element binder

Do you know where they are? Rider couldn't find any references to MauiButtonEventsBinder for me...

[aritchie]

Sentry.Maui/Internals/MauiButtonEventsBinder & Sentry.Maui/Internals/MauiImageButtonEventsBinder

[jamescrosswell]

Sentry.Maui/Internals/MauiButtonEventsBinder & Sentry.Maui/Internals/MauiImageButtonEventsBinder

Yeah I saw the classes... I didn't see the tests. I think this is them though:

sentry-dotnet/test/Sentry.Maui.Tests/MauiEventsBinderTests.Button.cs

Lines 7 to 31 in a1a90eb

	[Theory]
	[InlineData(nameof(Button.Clicked))]
	[InlineData(nameof(Button.Pressed))]
	[InlineData(nameof(Button.Released))]
	public void Button_CommonEvents_AddsBreadcrumb(string eventName)
	{
	// Arrange
	var button = new Button
	{
	StyleId = "button"
	};
	var el = new ElementEventArgs(button);
	_fixture.Binder.OnApplicationOnDescendantAdded(null, el);
	// Act
	button.RaiseEvent(eventName, EventArgs.Empty);
	// Assert
	var crumb = Assert.Single(_fixture.Scope.Breadcrumbs);
	Assert.Equal($"{nameof(Button)}.{eventName}", crumb.Message);
	Assert.Equal(BreadcrumbLevel.Info, crumb.Level);
	Assert.Equal(MauiEventsBinder.UserType, crumb.Type);
	Assert.Equal(MauiEventsBinder.UserActionCategory, crumb.Category);
	crumb.Data.Should().Contain($"{nameof(Button)}.Name", "button");
	}

[albyrock87]

@jamescrosswell I'm sorry for this late review but I just realized there's a huge bug here.

What about breadcrumb.ExtraData? I think you completely missed it.

Also I don't find the ExtraData type very convenient.

I think that this could be more convenient:

public record BreadcrumbEvent(
    object? Sender,
    string EventName,
    params (string Key, string Value)[] ExtraData
);

[albyrock87]

internal void OnBreadcrumbCreateCallback(BreadcrumbEvent breadcrumb)
    {
        void AddExtraData(Dictionary<string, string> extraData)
        {
            foreach (var data in breadcrumb.ExtraData.SelectMany(d => d))
            {
                extraData[data.Key] = data.Value;
            }
        }

        _hub.AddBreadcrumbForEvent(
            _options,
            breadcrumb.Sender,
            breadcrumb.EventName,
            UserType,
            UserActionCategory,
            AddExtraData
        );
    }

[jamescrosswell]

Good catch @albyrock87 - I've added #4252 to track this:

• BreadcrumbEvent.ExtraData not captured in MauiEventsBinder #4252