Skip to content

BreadcrumbEvent.ExtraData not captured in MauiEventsBinder #4252

@jamescrosswell

Description

@jamescrosswell

@jamescrosswell I'm sorry for this late review but I just realized there's a huge bug here.

What about breadcrumb.ExtraData? I think you completely missed it.

Also I don't find the ExtraData type very convenient.

I think that this could be more convenient:

public record BreadcrumbEvent(
    object? Sender,
    string EventName,
    params (string Key, string Value)[] ExtraData
);

Originally posted by @albyrock87 in #3997 (comment)

Metadata

Metadata

Labels

.NETPull requests that update .net codeBugSomething isn't working
No fields configured for issues without a type.

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions