Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect exception to transaction #1043

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 4, 2021

Resolves #1042

@bruno-garcia bruno-garcia requested a review from Tyrrrz as a code owner June 4, 2021 18:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #1043 (e09545a) into main (f60e3d7) will decrease coverage by 1.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   81.53%   79.86%   -1.67%     
==========================================
  Files         190      190              
  Lines        5967     5974       +7     
  Branches     1469     1471       +2     
==========================================
- Hits         4865     4771      -94     
- Misses        678      788     +110     
+ Partials      424      415       -9     
Impacted Files Coverage Δ
src/Sentry.AspNetCore/SentryTracingMiddleware.cs 75.00% <100.00%> (+2.53%) ⬆️
src/Sentry/Internal/Hub.cs 66.08% <100.00%> (ø)
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-71.24%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 33.33% <0.00%> (-66.67%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60e3d7...e09545a. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia enabled auto-merge (squash) June 4, 2021 18:41
@bruno-garcia bruno-garcia merged commit fb47553 into main Jun 4, 2021
@bruno-garcia bruno-garcia deleted the fix/tracing-exception branch June 4, 2021 18:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- connect exception to transaction ([#1043](https://github.com/getsentry/sentry-dotnet/pull/1043))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against e09545a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryTracingMiddleware doesn't connect exception to trace-id
3 participants