Attempt to fix danger (#1039)

getsentry · Jun 3, 2021 · f60e3d7 · f60e3d7
1 parent b492d45
commit f60e3d7
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/dangerfile.js b/dangerfile.js
@@ -10,26 +10,27 @@ async function checkChangelog() {
     const changelogFile = "CHANGELOG.md";
 
     // Check if skipped
-    const skipChangelog =
-        danger.github && (danger.github.pr.body + "").includes("#skip-changelog");
-
+    const skipChangelog = danger.github && (danger.github.pr.body + "").includes("#skip-changelog");
     if (skipChangelog) {
         return;
     }
 
     // Check if current PR has an entry in changelog
-    const changelogContents = await danger.github.utils.fileContents(
-        changelogFile
-    );
-
-    const hasChangelogEntry = RegExp(`#${danger.github.pr.number}\\b`).test(
-        changelogContents
-    );
+    const changelogContents = await danger.github.utils.fileContents(changelogFile);
 
+    const hasChangelogEntry = RegExp(`#${danger.github.pr.number}\\b`).test(changelogContents);
     if (hasChangelogEntry) {
         return;
     }
 
+    // Short-circuit if lacking permissions
+    const hasCommentPermission = danger.github.pr.head.repo.git_url == danger.github.pr.base.repo.git_url;
+    if (!hasCommentPermission) {
+        console.log("Please consider adding a changelog entry for the next release.");
+        process.exitCode = 1;
+        return;
+    }
+
     // Report missing changelog entry
     fail(
         "Please consider adding a changelog entry for the next release.",