Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix danger #1039

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Attempt to fix danger #1039

merged 3 commits into from
Jun 3, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jun 3, 2021

Not 100% sure what exactly is failing currently because the errors lack stacktraces, but looking at the previous version of the file (https://github.com/getsentry/sentry-dotnet/blob/04214d80af1c2be70450cc0c833828bc24ba164e/dangerfile.js) this seems to be the only thing that stands out.

Also can't really test it out until someone external makes a PR :/

image

#skip-changelog

Fixes #1004

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #1039 (8b23a60) into main (b492d45) will decrease coverage by 1.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   81.53%   79.85%   -1.68%     
==========================================
  Files         190      190              
  Lines        5967     5967              
  Branches     1469     1469              
==========================================
- Hits         4865     4765     -100     
- Misses        678      788     +110     
+ Partials      424      414      -10     
Impacted Files Coverage Δ
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-71.24%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 33.33% <0.00%> (-66.67%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 84.93% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b492d45...8b23a60. Read the comment docs.

@lucas-zimerman
Copy link
Collaborator

forking the project and making the same PR wouldn't help for testing Danger behavior?

@bruno-garcia
Copy link
Member

@lucas-zimerman if I remove you from the repo, yes we can do that to test it out.
Or we can wait for the next external PR

@bruno-garcia bruno-garcia enabled auto-merge (squash) June 3, 2021 18:21
@bruno-garcia bruno-garcia merged commit f60e3d7 into main Jun 3, 2021
@bruno-garcia bruno-garcia deleted the try-fix-danger branch June 3, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Danger is broken
4 participants