-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix React Native Onboarding Option Buttons #12813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! 🛠️
* master: (45 commits) feat: Mention that the cookie-sync extension works for previews (#12858) ref(flags): update unleashIntegration param (#12795) ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801) docs(python): Clarify how to init SDK in `async` app (#12854) move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786) docs(span-links): Add develop docs for span links (#12829) feat(java): add Reactor integration docs (#12686) Add Quarkus to community maintained SDKs (#12834) Adding unsupported hot reload (#12683) Fix broken links (#12844) feat(python): Clarification regarding start_transaction (#12835) docs(flutter): Fix event serverName reset in samples (#12832) ref(insights): move performance docs under insights (#12720) Bump API schema to 2e61347a (#12836) fix(apple): Usages of sendDefaultPii (#12833) Add `sendDefaultPii: true` to React Native init code snippets (#12812) Only show Browser vs React Native source maps alert for browser sdks (#12816) Add Data Collected page for React Native (#12811) Fix React Native Onboarding Option Buttons (#12813) Add Hono guide (#12710) ...
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
The line numbers of the code snippet are off and the buttons to show and hide do not work because of that.
This also added the options to the Expo setup and moved the buttons closer to the code.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES