Add sendDefaultPii: true to React Native init code snippets
#12812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
kahest
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
@krystofwoldrich we don't need to add the flag to all snippets, only onboarding docs which explain how to setup the SDK from scratch.
we should only add it in feature setup snippets (e.g. expo router) if sendDefaultPii is almost required for it. I think most of the snippets in this PR don't need it, but I'll let you decide. if you wanna keep it for specific feature, would be good to add in the comment what it's needed for
coolguyzone
reviewed
Feb 24, 2025
coolguyzone
reviewed
Feb 24, 2025
coolguyzone
reviewed
Feb 24, 2025
docs/platforms/react-native/tracing/instrumentation/custom-navigation.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Feb 24, 2025
docs/platforms/react-native/tracing/instrumentation/expo-router.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Feb 24, 2025
docs/platforms/react-native/tracing/instrumentation/user-interaction-instrumentation.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Feb 24, 2025
coolguyzone
reviewed
Feb 24, 2025
coolguyzone
reviewed
Feb 24, 2025
platform-includes/performance/configure-sample-rate/react-native.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Looks good! Please make sure you merge #12811 first so that the URLs in the comments work 🛳️
krystofwoldrich
force-pushed
the
kw-rn-add-default-pii-code-snippets
branch
from
566d6f4 to
5af8f6d
Compare
codyde
added a commit
that referenced
this pull request
Feb 27, 2025
* master: (45 commits) feat: Mention that the cookie-sync extension works for previews (#12858) ref(flags): update unleashIntegration param (#12795) ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801) docs(python): Clarify how to init SDK in `async` app (#12854) move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786) docs(span-links): Add develop docs for span links (#12829) feat(java): add Reactor integration docs (#12686) Add Quarkus to community maintained SDKs (#12834) Adding unsupported hot reload (#12683) Fix broken links (#12844) feat(python): Clarification regarding start_transaction (#12835) docs(flutter): Fix event serverName reset in samples (#12832) ref(insights): move performance docs under insights (#12720) Bump API schema to 2e61347a (#12836) fix(apple): Usages of sendDefaultPii (#12833) Add `sendDefaultPii: true` to React Native init code snippets (#12812) Only show Browser vs React Native source maps alert for browser sdks (#12816) Add Data Collected page for React Native (#12811) Fix React Native Onboarding Option Buttons (#12813) Add Hono guide (#12710) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES