-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[v9] Encourage using inheritOrSampleWith
for tracesSampler
in js
#12544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Not directly related, but when we update this again, let's make sure to remove this line on this page too:
|
I think we can update this already now |
parentSampleRate
for tracesSampler
in jsinheritOrSampleWith
for tracesSampler
in js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
inheritOrSampleWith
for tracesSampler
in jsinheritOrSampleWith
for tracesSampler
in js
inheritOrSampleWith
for tracesSampler
in jsinheritOrSampleWith
for tracesSampler
in js
DESCRIBE YOUR PR
Swaps over to documenting
inheritOrSampleWith
over parentSampled as migration guide for v9. Wasn't done with a versioned docs page because it was too annoying.Resolves getsentry/sentry-javascript#15124
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.