-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(flags): update python onboarding docs to include second step #11970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 162 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
@@ -44,3 +44,11 @@ sentry_sdk.capture_exception(Exception("Something went wrong!")) | |||
``` | |||
|
|||
Visit the Sentry website and confirm that your error event has recorded the feature flag "hello" and its value "false". | |||
|
|||
Please read the note below to ensure that you also complete one additional step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence might be extraneous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I think the note will draw the reader's attention, you probably don't need this callout.
|
||
In order to take full advantage of the feature flag capabilities Sentry offers, there is an additional setup step needed, which is setting up your integration-specific webhook. This is needed to enable **feature flag change tracking**, so that your integration may communicate feature flag changes to Sentry. Learn how to set this up by [reading the docs](/product/explore/feature-flags/#set-up-your-integration-specific-webhook). | ||
|
||
</Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should direct users both to other SDK languages they might need languages AND to the webhook stuff:
Next Steps:
- track feature flag evaluations in other parts of your codebase
- setup feature flag change tracking webhook
idk
It could also be something similar to the other PR... this paragraph (from #11969) but with links; maybe condensed somehow:
In order to take advantage of the full feature flag experience available, there are two steps necessary to set up feature flag evaluation tracking and feature flag change tracking. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'll be valuable to put this <Alert>
into it's own file and import it into these two files. Over time there will be more languages and thus more files that'll reference it again and again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
72bfe02
to
ab443b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🕺
@@ -0,0 +1,8 @@ | |||
Please read the note below to ensure that you also complete one additional step. | |||
|
|||
<Alert level="warning" title="Next Steps"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why don't we have the set up for feature flag changes and evaluations instructions embedded on this integrations page? 🤔
I think there's some consolidating we could do
add info to the python-specific launchdarkly & openfeature onboarding docs to let users know that there's a second step needed to set up feature flags completely!
figjam ref mapping out the docs
updated note:
