feat(flags): Add browser JS integration docs for Launchdarkly #11839

cmanallen · 2024-11-15T20:48:48Z

Re-adds LaunchDarkly integration documentation.

…chdarkly…" This reverts commit 39f14ed.

vercel · 2024-11-15T20:48:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 9:07pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
changelog	⬜️ Ignored (Inspect)	Visit Preview		Nov 15, 2024 9:07pm
develop-docs	⬜️ Ignored (Inspect)			Nov 15, 2024 9:07pm

codecov · 2024-11-15T20:54:34Z

Bundle Report

Changes will increase total bundle size by 258 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
sentry-docs-server-cjs	8.59MB	264 bytes (0.0%) ⬆️
sentry-docs-client-array-push	8.94MB	6 bytes (-0.0%) ⬇️

lizokm

Thanks for adding!

lizokm · 2024-11-18T21:08:24Z

docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx

@@ -0,0 +1,54 @@
+---
+title: LaunchDarkly
+description: "Attaches recent LaunchDarkly feature flag evaluations to error event context."


Suggested change

description: "Attaches recent LaunchDarkly feature flag evaluations to error event context."

description: "Learn how to attach LaunchDarkly feature flag evaluations to error event context."

@cmanallen Should this be expanded to feature flag change tracking?

Is this too verbose? "Learn how to attach recent LaunchDarkly feature flag evaluations to your error event context"

@cmanallen Should this be expanded to feature flag change tracking?

@jas-kas The SDK integration doesn't track FF changes, only evaluations leading up to the error. Changes are tracked through the webhook, maybe we can link the docs for that

^ basically +1 to Michelle's comment below!

lizokm · 2024-11-18T21:10:49Z

docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx

+
+The [LaunchDarkly](https://launchdarkly.com/) integration tracks feature flag evaluations produced by the LaunchDarkly SDK. These evaluations are held in memory and, in the event an error occurs, sent to Sentry for review and analysis. **At the moment, we only support boolean flag evaluations.**


Suggested change

The [LaunchDarkly](https://launchdarkly.com/) integration tracks feature flag evaluations produced by the LaunchDarkly SDK. These evaluations are held in memory and, in the event an error occurs, sent to Sentry for review and analysis. **At the moment, we only support boolean flag evaluations.**

The [LaunchDarkly](https://launchdarkly.com/) integration tracks feature flag evaluations produced by the LaunchDarkly SDK. These evaluations are held in memory and, if an error occurs, sent to Sentry for review and analysis. **At the moment, we only support boolean flag evaluations.**

lizokm · 2024-11-18T21:11:22Z

docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx

+Learn more about the LaunchDarkly SDK at https://docs.launchdarkly.com/sdk/client-side/javascript.
+At the moment, **we do not officially support framework-specific LaunchDarkly
+SDKs.** However, you may reuse this setup code for React and client-side Node.js.


Suggested change

Learn more about the LaunchDarkly SDK at https://docs.launchdarkly.com/sdk/client-side/javascript.

At the moment, **we do not officially support framework-specific LaunchDarkly

SDKs.** However, you may reuse this setup code for React and client-side Node.js.

Learn more about the [LaunchDarkly SDK] (https://docs.launchdarkly.com/sdk/client-side/javascript).

At the moment, **we don't officially support framework-specific LaunchDarkly

SDKs.** However, you can reuse this setup code for React and client-side Node.js.

lizokm · 2024-11-18T21:11:50Z

docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx

+## Options
+
+There are no setup options for this integration.


Suggested change

## Options

There are no setup options for this integration.

## Options

There are no setup options for this integration.

Same comment as for open feature - maybe it's best to delete this section?

I left it in so we'd remember to update it if we add options in the future. Don't have strong opinions on this though

michellewzhang · 2024-11-27T07:26:24Z

we should make it clear that there's another step to setting up flags (the change tracking / webhook step). can link to the index docs in this PR: #11969. can mirror the changes made here: #11970

see figjam for full map!

jas-kas · 2024-11-29T21:15:31Z

Should we also include this step right here on this docs page https://github.com/getsentry/sentry-docs/pull/11971/files#r1863929949?

jas-kas

Looks good! Main comment is should we expand this to talk about set up for feature flag change tracking, not just evaluation?

jas-kas · 2024-11-29T21:12:50Z

docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx

@@ -0,0 +1,54 @@
+---
+title: LaunchDarkly
+description: "Attaches recent LaunchDarkly feature flag evaluations to error event context."


@cmanallen Should this be expanded to feature flag change tracking?

jas-kas · 2024-11-29T21:13:28Z

docs/platforms/javascript/common/configuration/integrations/launchdarkly.mdx

+
+<Alert level="info">
+
+This integration only works inside a browser environment.


Should we re-frame this to just call out JavaScript and Python as supported SDKs?

ryan953 · 2024-12-02T17:34:57Z

looks like this got pulled into the big docs PR here: https://github.com/getsentry/sentry-docs/pull/12005/files#diff-3365be2e16bf22c9c585399fe09132f3aaaa952585587745a54a0f114dfbc7fb

closing this so we can focus there.

Revert "Revert "feat(flags): add browser JS integration docs for Laun…

e193886

…chdarkly…" This reverts commit 39f14ed.

vercel bot deployed to Preview – sentry-docs November 15, 2024 21:07 View deployment

lizokm self-requested a review November 18, 2024 21:07

lizokm approved these changes Nov 18, 2024

View reviewed changes

ryan953 mentioned this pull request Nov 20, 2024

docs(flags): add index flag docs for python #11879

Closed

jas-kas approved these changes Nov 29, 2024

View reviewed changes

ryan953 closed this Dec 2, 2024

github-actions bot locked and limited conversation to collaborators Dec 18, 2024

	description: "Attaches recent LaunchDarkly feature flag evaluations to error event context."
	description: "Learn how to attach LaunchDarkly feature flag evaluations to error event context."


		The [LaunchDarkly](https://launchdarkly.com/) integration tracks feature flag evaluations produced by the LaunchDarkly SDK. These evaluations are held in memory and, in the event an error occurs, sent to Sentry for review and analysis. At the moment, we only support boolean flag evaluations.


		<Alert level="info">

		This integration only works inside a browser environment.

Uh oh!

feat(flags): Add browser JS integration docs for Launchdarkly #11839

feat(flags): Add browser JS integration docs for Launchdarkly #11839

Uh oh!

Conversation

cmanallen commented Nov 15, 2024

Uh oh!

vercel bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

lizokm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michellewzhang commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jas-kas commented Nov 29, 2024

Uh oh!

jas-kas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryan953 commented Dec 2, 2024

Uh oh!

Uh oh!

vercel bot commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

michellewzhang commented Nov 27, 2024 •

edited

Loading