parse and report async gaps #1

yjbanov · 2017-08-02T06:45:29Z

eseidelGoogle · 2017-08-02T13:44:10Z

Isn't crashy able to tell us if this fixes things? :)

yjbanov · 2017-08-02T16:07:17Z

This PR does not fix missing async stack traces. It only fixes missing async gaps, should they appear in the stack. I just confirmed using crashy that release builds are indeed missing async stack traces. Will comment in the original issue.

cbracken · 2017-08-07T21:16:37Z

lib/src/stack_trace.dart

+    frames.addAll(chain.traces[t].frames.map(encodeStackTraceFrame));
+    if (t < chain.traces.length - 1) {
+      frames.add(asynchronousGapFrameJson);
+    }


Drop the curly brackets for one-line ifs.

cbracken · 2017-08-07T21:18:11Z

lib/src/stack_trace.dart

+      : new Chain.parse(stackTrace);
+
+  final List<Map<String, dynamic>> frames = <Map<String, dynamic>>[];
+  for (int t = 0; t < chain.traces.length; t += 1) {


Why not t++?

That's Flutter style.

cbracken · 2017-08-07T21:19:17Z

Update isolate_error_integration.dart

* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG

* melos setup #1: initial set up and start with dart package (#3117) * Add melos setup and check only set up Dart for now * Update * Update * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * melos #2: logging package (#3129) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * melos #3: dio (#3130) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * melos #4: hive (#3131) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * melos #5: file (#3132) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Update file.yml * melos #6: link (#3133) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * melos #7: drift (#3134) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Update drift.yml * melos #8: flutter (#3135) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * melos #9: isar (#3136) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #10: sqflite (#3137) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #11: firebase remote config (#3139) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #12: general cleanup (#3142) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * Updaet * Updaet * Update * update

…rt` (#3147) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * melos setup #1: initial set up and start with dart package (#3117) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * melos #2: logging package (#3129) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * melos #3: dio (#3130) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * melos #4: hive (#3131) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * melos #5: file (#3132) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Update file.yml * melos #6: link (#3133) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * melos #7: drift (#3134) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Update drift.yml * melos #8: flutter (#3135) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * melos #9: isar (#3136) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #10: sqflite (#3137) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #11: firebase remote config (#3139) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Updaet * Updaet * Update * melos #12: general cleanup (#3142) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * Updaet * Updaet * Update * Update * Update * update * update

parse and report async gaps

64b6154

yjbanov mentioned this pull request Aug 2, 2017

Async stack traces missing from Sentry crash reports flutter/flutter#11479

Closed

cbracken approved these changes Aug 7, 2017

View reviewed changes

yjbanov added 2 commits August 7, 2017 14:34

address comments

2e1a698

dartfmt

c01562e

yjbanov merged commit b2b5afc into getsentry:master Aug 7, 2017

fzyzcjy mentioned this pull request Mar 6, 2021

null safety on sentry_flutter #337

Merged

5 tasks

ueman pushed a commit that referenced this pull request Jul 19, 2021

Merge pull request #1 from HugoSart/main

5f74616

Update isolate_error_integration.dart

lauroboeni mentioned this pull request Sep 23, 2021

MissingPluginException #599

Closed

11 tasks

This was referenced Dec 24, 2021

Error in console when calling Sentry.captureException #680

Closed

Expandos are not allowed on strings, numbers, booleans or null): #681

Closed

marandaneto mentioned this pull request Jan 18, 2022

Enhancement: Use compute to offload heavy work from the main thread #707

Closed

5 tasks

vamsi575kg mentioned this pull request Feb 10, 2022

Logging not working in flutter sentry's ios version on a self hosted sentry server version Sentry 20.11.1 4468076 #748

Closed

marandaneto mentioned this pull request Apr 1, 2022

Automatically detect package name for in-app-frame detection #818

Closed

marandaneto mentioned this pull request May 5, 2023

Improve SentryException#value, remove stringified stack trace #1421

Closed

marandaneto mentioned this pull request May 26, 2023

Sentry Flutter Android does not capture any exceptions at all when custom initialization - caused by callback failure, thus would be great to add a log / throw when this happens #1486

Closed

hirensamtani mentioned this pull request May 29, 2023

Reopening the Zone mismatch issue #1494

Closed

pvermaDM mentioned this pull request Jun 24, 2024

Sentry Upgrade in flutter causing other testcases to fail. #2126

Closed

vgrysh mentioned this pull request Oct 4, 2024

ANR details SourceFile - io.sentry.android.core.u.g #2328

Closed

buenaflor mentioned this pull request Nov 12, 2024

feat(js-sdk): add script loader to set up Sentry Javascript SDK #2406

Merged

6 tasks

richanshah mentioned this pull request Nov 19, 2024

Crash: stacktrace_utils.dart in getCurrentStackTrace within sentry #2146

Closed

fodedoumbouya mentioned this pull request Dec 16, 2024

type 'NoOpSentrySpan' is not a subtype of type 'SentryTracer' in type cast #2500

Closed

geosebas mentioned this pull request Apr 15, 2025

Capture exception with setContexts not working #2867

Closed

buenaflor mentioned this pull request Jul 30, 2025

melos setup #1: initial set up and start with dart package #3117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

parse and report async gaps #1

parse and report async gaps #1

Uh oh!

yjbanov commented Aug 2, 2017 •

edited

Loading

Uh oh!

eseidelGoogle commented Aug 2, 2017

Uh oh!

yjbanov commented Aug 2, 2017

Uh oh!

cbracken Aug 7, 2017

Uh oh!

yjbanov Aug 7, 2017

Uh oh!

cbracken Aug 7, 2017

Uh oh!

yjbanov Aug 7, 2017

Uh oh!

cbracken commented Aug 7, 2017

Uh oh!

Uh oh!

Uh oh!

parse and report async gaps #1

parse and report async gaps #1

Uh oh!

Conversation

yjbanov commented Aug 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eseidelGoogle commented Aug 2, 2017

Uh oh!

yjbanov commented Aug 2, 2017

Uh oh!

cbracken Aug 7, 2017

Choose a reason for hiding this comment

Uh oh!

yjbanov Aug 7, 2017

Choose a reason for hiding this comment

Uh oh!

cbracken Aug 7, 2017

Choose a reason for hiding this comment

Uh oh!

yjbanov Aug 7, 2017

Choose a reason for hiding this comment

Uh oh!

cbracken commented Aug 7, 2017

Uh oh!

Uh oh!

yjbanov commented Aug 2, 2017 •

edited

Loading