-
-
Notifications
You must be signed in to change notification settings - Fork 271
enh: improve envelope conversion to Uint8List
in FileSystemTransport
#3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Update file.yml
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Update drift.yml
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * Updaet * Updaet * Update
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
==========================================
+ Coverage 87.66% 89.90% +2.23%
==========================================
Files 291 96 -195
Lines 9884 3427 -6457
==========================================
- Hits 8665 3081 -5584
+ Misses 1219 346 -873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Do we need to keep the benchmark test around?
@denrase I'd just keep it there |
💡 Motivation and Context
Performance improvement by avoiding a copy
Benchmarks tested on release mode on Android
💚 How did you test it?
Manual + existing tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps