Skip to content

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Aug 8, 2025

Blocked by getsentry/sentry-cli#2691
Blocked by #327

📜 Description

Adds support for uploading dart symbol maps

💡 Motivation and Context

Part of getsentry/sentry-dart#2805

💚 How did you test it?

Unit, integration, manual

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 08b9690

@buenaflor buenaflor changed the base branch from feat/find-relevant-debug-files to main August 12, 2025 12:12
@buenaflor buenaflor marked this pull request as ready for review August 14, 2025 13:10
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@buenaflor buenaflor requested a review from denrase August 14, 2025 13:56
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, just glanced over and gave general feedback. Please also make sure we have all possible cases in _prependDebugIdMarkerToMapFile covered:

  • file without marker
  • file with other marker
  • file with same marker

TODOs should also either be resolved or issues created for them, otherwise they might linger around forever and the next one might not have enough context to resolve them.

cursor[bot]

This comment was marked as outdated.

@buenaflor buenaflor enabled auto-merge (squash) August 14, 2025 18:24
@buenaflor buenaflor merged commit cdc6e60 into main Aug 14, 2025
20 checks passed
@buenaflor buenaflor deleted the feat/find-mapping-file branch August 14, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants