-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat(symbolication): upload dart symbol mapping file #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, just glanced over and gave general feedback. Please also make sure we have all possible cases in _prependDebugIdMarkerToMapFile
covered:
- file without marker
- file with other marker
- file with same marker
TODOs should also either be resolved or issues created for them, otherwise they might linger around forever and the next one might not have enough context to resolve them.
Blocked by getsentry/sentry-cli#2691
Blocked by #327
📜 Description
Adds support for uploading dart symbol maps
💡 Motivation and Context
Part of getsentry/sentry-dart#2805
💚 How did you test it?
Unit, integration, manual
📝 Checklist
🔮 Next steps