-
-
Notifications
You must be signed in to change notification settings - Fork 235
feat(dart): add dart-symbol-map upload
command
#2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll try to do a fuller review before I head into vacation from Tuesday afternoon – but in case I don't get to, and you request review from someone else, just want to leave an initial thought here: I would suggest that instead of naming this command The reason is that this aligns with the APIs for |
Thanks, will update the command |
upload-dart-symbol-map
commanddart-symbol-map upload
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As currently written, this command will use way more memory than needed. Please address these, and also restructure the code as requested.
Feel free to dismiss my review once fixing these, if I am still on vacation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have you verified that it works with Sentry?
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
thx, yes works as expected |
approved review by another reviewer
Adds support for uploading dart symbol maps that are associated via debug id extracted from the provided debug file
example usage:
Tests:
Part of getsentry/sentry-dart#2805