Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Oct 29, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.293%. Comparing base (f376191) to head (5fb0f9a).
⚠️ Report is 4 commits behind head on denrase/swift-log-sentry-poc.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           denrase/swift-log-sentry-poc     #6588       +/-   ##
==================================================================
- Coverage                        85.504%   85.293%   -0.212%     
==================================================================
  Files                               452       452               
  Lines                             27470     27470               
  Branches                          11934     11936        +2     
==================================================================
- Hits                              23488     23430       -58     
- Misses                             3698      3995      +297     
+ Partials                            284        45      -239     
Files with missing lines Coverage Δ
...ces/Sentry/Profiling/SentryProfilerSerialization.m 64.435% <ø> (ø)
Sources/Sentry/SentryCrashIntegration.m 98.936% <ø> (ø)
Sources/Sentry/SentryCrashScopeObserver.m 94.029% <ø> (ø)
Sources/Sentry/SentryEnvelopeAttachmentHeader.m 100.000% <ø> (ø)
Sources/Sentry/SentryEvent.m 98.979% <ø> (ø)
Sources/Sentry/SentryException.m 100.000% <ø> (ø)
Sources/Sentry/SentryFileManagerHelper.m 88.116% <ø> (ø)
Sources/Sentry/SentryMechanism.m 100.000% <ø> (ø)
Sources/Sentry/SentryMechanismMeta.m 100.000% <ø> (ø)
Sources/Sentry/SentryScope.m 97.080% <ø> (ø)
... and 7 more

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f376191...5fb0f9a. Read the comment docs.

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentrySerialization.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants