Skip to content

feat(backport): Update sourcemap to 6.2.3 #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2023
Merged

feat(backport): Update sourcemap to 6.2.3 #1586

merged 2 commits into from
Apr 24, 2023

Conversation

loewenheim
Copy link
Contributor

This updates the sourcemap dependency to 6.2.3 in order to make this fix accessible in v1 of sentry-cli. The changes to src/utils/sourcemap.rs are taken from 94bc533, the commit that updated sourcemap from 5.x.x to 6.x.x in v2.

@loewenheim loewenheim changed the title fix: Update sourcemap to 6.2.3 feat(backport): Update sourcemap to 6.2.3 Apr 21, 2023
Lms24
Lms24 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with an Angular app. Frames are now marked in_app: true as expected:

image

Thanks a lot for doing this so quickly!

@loewenheim loewenheim merged commit b7819ab into 1.x Apr 24, 2023
@loewenheim loewenheim deleted the fix/backport-sourcemap branch April 24, 2023 09:47
@kamilogorek kamilogorek mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loewenheim @Lms24