-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Support GitHub release title pattern matching #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Issue #85 by adding a new `gh-title-pattern` input parameter that allows filtering releases by GitHub release titles using regex patterns. Features: - Filter releases by title patterns (e.g., '\(Stable\)$' for stable releases) - Uses GitHub API to fetch release metadata - Fully backward compatible when parameter is not specified - Comprehensive test coverage with error handling Usage example: ```yaml uses: getsentry/github-workflows/updater@v3 with: path: modules/sentry-cocoa name: Cocoa SDK (Stable) gh-title-pattern: '\(Stable\)$' ``` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The --paginate flag returns separate pages, not combined results. Using the default API call (first 30 releases) is sufficient for most repositories when filtering by release title patterns. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Simplify the implementation with: - Consolidated URL validation with single regex match - Cleaner variable assignment using tuple unpacking - Simplified array handling by wrapping API result in @() - Removed unnecessary null/single object checks - More concise comments and clearer logic flow 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…in update-dependency.ps1
- Add test that matches exact release version (2.11.1) by title pattern - This provides a deterministic test case that verifies exact behavior - Fix error handling to ensure proper error message when no releases match - All 4 gh-title-pattern tests now pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Documents the new gh-title-pattern feature that allows users to filter releases by their GitHub release titles using regex patterns. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Ensures that gh api commands work properly in CI environments by setting the GH_TOKEN environment variable to the provided api-token input. This fixes the issue where GitHub release title filtering would fail silently in CI due to lack of authentication. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
@sentry review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #85 by adding a new
gh-title-pattern
input parameter for filtering releases by GitHub release titles using regex patterns.Changes
gh-title-pattern
input parameter toaction.yml
update-dependency.ps1
to fetch release metadataFeatures
\(Stable\)$
gh api
with pagination for efficient data fetchingUsage Example
Test Results
All tests pass, including:
Implementation Details
The implementation uses GitHub's REST API to fetch release metadata and filters tags based on release titles before applying the existing version pattern filtering. This ensures the feature works seamlessly with all existing functionality while providing the new release channel filtering capability.
🤖 Generated with Claude Code