fix: Danger and updater download script URLs cannot use GITHUB_WORKFLOW_REF #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds automated version management for Craft releases: - Creates scripts/update-version.ps1 to update _workflow_version defaults - Updates .craft.yml to use the script in preReleaseCommand - Script automatically updates danger.yml and updater.yml workflow defaults 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Ensures the PowerShell script properly quotes version values in YAML to maintain valid syntax when updating _workflow_version defaults. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Documents the addition of PowerShell version update script and the revert from GITHUB_WORKFLOW_REF back to _workflow_version parameter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The core problem is that script download URLs cannot use GITHUB_WORKFLOW_REF when workflows are called from other repositories. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove implementation details about Craft automation and focus on the main issue: GITHUB_WORKFLOW_REF cannot be used for script download URLs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
vaind
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where danger and updater workflows cannot download scripts when called from other repositories because
GITHUB_WORKFLOW_REFrefers to the calling repository's context, not thegithub-workflowsrepository where the scripts are located.Background
When reusable workflows are called from other repositories,
GITHUB_WORKFLOW_REFpoints to the calling repository's context, not thegithub-workflowsrepository where our scripts are located. This causes script downloads to fail because the URLs point to the wrong repository.Changes
_workflow_versioninput parameter in bothdanger.ymlandupdater.ymlscripts/update-version.ps1to update_workflow_versiondefaults.craft.ymlto use the script inpreReleaseCommand${{ github.sha }}for the_workflow_versionparameterTest plan
v2→v3)2.14.1→2.15.0)_workflow_versionparameter🤖 Generated with Claude Code