fix: Use GITHUB_WORKFLOW_REF instead of _workflow_version input #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
changed the title
Automatically determines the workflow reference from GITHUB_WORKFLOW_REF instead of requiring manual _workflow_version input parameter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove _workflow_version input parameter and automatically determine the workflow reference from GITHUB_WORKFLOW_REF instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
vaind
force-pushed
the
vaind-patch-1
branch
from
05915c0 to
758c299
Compare
vaind
changed the title
…ut step The workflow was failing because it used shell syntax (bash) in a PowerShell context. Converted the shell commands to proper PowerShell equivalents: - Variable assignment using PowerShell syntax - mkdir -> New-Item with -Force flag - cd -> Set-Location - regex replacement using PowerShell -replace operator 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
vaind
added a commit
that referenced
this pull request
Sep 22, 2025
…OW_REF (#111) * Revert "fix: Use GITHUB_WORKFLOW_REF instead of _workflow_version input (#109)" This reverts commit bdf2970. * feat: Add PowerShell script for Craft release version updates Adds automated version management for Craft releases: - Creates scripts/update-version.ps1 to update _workflow_version defaults - Updates .craft.yml to use the script in preReleaseCommand - Script automatically updates danger.yml and updater.yml workflow defaults 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: Update default workflow version to 2.14.1 in danger and updater workflows * fix: Add proper YAML quoting to version update script Ensures the PowerShell script properly quotes version values in YAML to maintain valid syntax when updating _workflow_version defaults. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: Add changelog entry for Craft automation and workflow fix Documents the addition of PowerShell version update script and the revert from GITHUB_WORKFLOW_REF back to _workflow_version parameter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: Update changelog entry to clarify GITHUB_WORKFLOW_REF issue The core problem is that script download URLs cannot use GITHUB_WORKFLOW_REF when workflows are called from other repositories. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: Simplify changelog entry to focus on the core fix Remove implementation details about Craft automation and focus on the main issue: GITHUB_WORKFLOW_REF cannot be used for script download URLs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_workflow_versioninput parameters with automatic detection fromGITHUB_WORKFLOW_REFChanges
GITHUB_WORKFLOW_REFto download dangerfile.js and utilitiesGITHUB_WORKFLOW_REFto checkout workflow scripts_workflow_versionparameters since they're no longer neededBenefits
🤖 Generated with Claude Code