Skip to content

Add REDASH_HOST to the development docker compose file #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

justinclift
Copy link
Member

@justinclift justinclift commented Sep 12, 2024

What type of PR is this?

  • Bug Fix

Description

Adding the full host and port to the compose file in our repository ensures emails generated in the development environment have the port number included in their urls.

How is this tested?

  • Manually

Screenshot of a generated invite email that includes this fix:

Screenshot 2024-09-12 at 3 48 58 PM

Related Tickets & Documents

#7153

This ensures emails generated in the development environment
have the port number included in their urls.
@justinclift justinclift changed the title Add REDASH_HOST to the docker compose file Add REDASH_HOST to the development docker compose file Sep 12, 2024
@justinclift justinclift enabled auto-merge (squash) September 12, 2024 09:01
@justinclift justinclift merged commit fb1a056 into master Sep 12, 2024
14 checks passed
@justinclift justinclift deleted the env_redash_host_v1 branch September 12, 2024 10:34
@zachliu
Copy link
Contributor

zachliu commented Sep 12, 2024

200w

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
This ensures emails generated in the development environment have the port number included in their urls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants