Not configure email can't invite new user?

[gaecoli]

When i use latest redash code with docker build up server, and i click settings -> users -> new user -> i set user name and user email. I find pending user with a Api key, and i use redash.xxxx.com/invite/<Api key>?org_slug=default, it show me Your invite link has expired. How to solve it?

[gaecoli]

I check out code

[gaecoli]

there is just one catch: when running locally, the invitation url doesn't have the port 5001

Ahhh. I wonder if that changes when REDASH_HOST is defined in the .env file?

Something along the lines of this is what I'm thinking:

REDASH_HOST=http://localhost:5001

Haven't tested it yet, as I'm not yet down at the local co-working centre. Should be there in about an hour though.

Maybe we should keep it.

[justinclift]

We can probably add REDASH_HOST to the auto-generated contents of .env without any problems:

redash/Makefile

Lines 39 to 40 in 76eeea1

	.env:
	printf "REDASH_COOKIE_SECRET=`pwgen -1s 32`\nREDASH_SECRET_KEY=`pwgen -1s 32`\n" >> .env

[gaecoli]

We can probably add REDASH_HOST to the auto-generated contents of .env without any problems:

redash/Makefile

Lines 39 to 40 in 76eeea1

	.env:
	printf "REDASH_COOKIE_SECRET=`pwgen -1s 32`\nREDASH_SECRET_KEY=`pwgen -1s 32`\n" >> .env

OK! It's a good idea!

[justinclift]

Thinking about it more, we should put it in the compose file directly where the other static values already are:

redash/compose.yaml

Lines 12 to 21 in d6c6e3b

	x-redash-environment: &redash-environment
	REDASH_LOG_LEVEL: "INFO"
	REDASH_REDIS_URL: "redis://redis:6379/0"
	REDASH_DATABASE_URL: "postgresql://postgres@postgres/postgres"
	REDASH_RATELIMIT_ENABLED: "false"
	REDASH_MAIL_DEFAULT_SENDER: "redash@example.com"
	REDASH_MAIL_SERVER: "email"
	REDASH_MAIL_PORT: 1025
	REDASH_ENFORCE_CSRF: "true"
	REDASH_GUNICORN_TIMEOUT: 60

I'll throw together a PR with that shortly. 😄

[gaecoli]

Thinking about it more, we should put it in the compose file directly where the other static values already are:

redash/compose.yaml

Lines 12 to 21 in d6c6e3b

	x-redash-environment: &redash-environment
	REDASH_LOG_LEVEL: "INFO"
	REDASH_REDIS_URL: "redis://redis:6379/0"
	REDASH_DATABASE_URL: "postgresql://postgres@postgres/postgres"
	REDASH_RATELIMIT_ENABLED: "false"
	REDASH_MAIL_DEFAULT_SENDER: "redash@example.com"
	REDASH_MAIL_SERVER: "email"
	REDASH_MAIL_PORT: 1025
	REDASH_ENFORCE_CSRF: "true"
	REDASH_GUNICORN_TIMEOUT: 60

I'll throw together a PR with that shortly. 😄

I support u.

[zachliu]

to sum up, two PRs are needed 😜

1. update the error message to reflect the actual error when token verification failed
2. when running locally, the invitation url should include the port

[gaecoli]

to sum up, two PRs are needed 😜

1. update the error message to reflect the actual error when token verification failed
2. when running locally, the invitation url should include the port

The first point is needed, but No.2 don't need, i look up master code, the invitation url will use your configuration REDASH_HOST url, so we don't need to add it.

[justinclift]

@gaecoli Cool, same thought. 😄

[justinclift]

This is a PR that adds REDASH_HOST to the compose file in our development repo, which fixes the missing port number problem with emails generated from our development environment: #7157

It doesn't fix anything with lousy showing of actual error messages though. 😉 That might be more @zachliu's kind of thing to take a look at?

[justinclift]

k, the REDASH_HOST part has been merged. The "improvement of error message" part still needs fixing though.

[gaecoli]

k, the REDASH_HOST part has been merged. The "improvement of error message" part still needs fixing though.

U can add a PR to fix it.

[justinclift]

Probably more a @zachliu thing than me just yet. 😄

[zachliu]

No problemo. I'll take a look today! 🫡