Update to formatSimpleTemplate to allow input in any case for Snowflake users #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting prop toUpperCase() to account for variability in user input
Adding support for caps and non-caps
matthew-smith-miller
changed the title
|
Thanks for this contribution! Just checking ahead of time: would the change in #5657 cover this use case? |
|
@susodapop Sorry for delay. I'm not sure -- need to look into it a bit more. |
susodapop
added
Needs More Information
|
No worries. When you have a chance please examine whether #5657 can resolve your need. Else we can reopen and do a full review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
In the chart builder, the user is instructed that they may reference any column value with
{{ column_name }}syntax:However, since our company uses Redash on top of Snowflake the input must be capitalized, or it will not work:
Doesn't work:
Works:
This update to the formatSimpleTemplate() attempts to retrieve a column value with
propas before, and as a backup tries withpropUpper, a capitalized version. This should fix the issue for any other users who use Snowflake.How is this tested?