snowflake: add option to lowercase column names #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susodapop
force-pushed
the
update-snowflake-connector
branch
from
bb8c8a4 to
681ca05
Compare
|
I rebased onto |
2 tasks
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Ported from app.redash.io codebase. * Add option to lowercase column names * Black the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR ports a feature from the app.redash.io snowflake query runner: an option to automatically lowercase column names returned by snowflake. This is important for users migrating from app.redash.io to OSS with
redash-migratebecause otherwise their visualisations won't work.Related Tickets & Documents
https://discuss.redash.io/t/sso-version-does-not-include-lower-case-column-names-in-results-when-connecting-with-snowflake/9470
Mobile & Desktop Screenshots/Recordings (if there are UI changes)