Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUM Theme: Only display "Tags" sidebar header if there are tags #567

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

stuaxo
Copy link
Contributor

@stuaxo stuaxo commented Oct 25, 2017

No description provided.

@JOduMonT
Copy link

in templates/sidebar.html
just have to move

<h4>Tags</h4>

after

{% if tags and tags %}

and add |length > 1

to the if

the result should be something like this


{% if tags and tags|length > 1 %}
<h4>Tags</h4>

@stuaxo
Copy link
Contributor Author

stuaxo commented Nov 23, 2017

I think thats what the affect of my if tag_cloud in this patch should be ?

But I'm definitely happy to change it if needs be

@JOduMonT
Copy link

Hi stuaxo;

I'm sorry I did'nt realize your PR was already what I was proposing ;)

@stuaxo
Copy link
Contributor Author

stuaxo commented Nov 24, 2017

Cheers - was just sanity checking what I did by asking that, good we're on the same page - maybe the pull request can be accepted now :D

@justinmayer
Copy link
Member

Thanks to @stuaxo for the fix and to @JOduMonT for reviewing.

@justinmayer justinmayer merged commit 808426e into getpelican:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants