Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gum theme: don't display sidebar pages headers if sections are empty #565

Open
stuaxo opened this issue Oct 25, 2017 · 2 comments
Open

gum theme: don't display sidebar pages headers if sections are empty #565

stuaxo opened this issue Oct 25, 2017 · 2 comments

Comments

@stuaxo
Copy link
Contributor

stuaxo commented Oct 25, 2017 •
edited
Loading

Pull requests

Pull 564 - Only display pages header needed
Pull 566 - Only display categories header if more than one
Pull 567 - Only display tags header if there are some tags

Without the fixes
screenshot from 2017-10-25 15-46-35

With the fixes
screenshot from 2017-10-25 15-46-56

Apologies for the inverted colours, this a bug in the gnome screenshotter.
@stuaxo stuaxo changed the title gum theme: don't display sidebar pages header if no pages gum theme: don't display sidebar pages headers if sections are empty Oct 25, 2017
@stuaxo
Copy link
Contributor Author

stuaxo commented Oct 27, 2017

Some of the logic in the site looks a little dubious in these bits, it would be great to get a sanity check for 564

@rask004
Copy link
Contributor

rask004 commented Oct 17, 2018

Sanity Checked: see feedback, #564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuaxo @rask004