Skip to content

Add navigation from tray directly to the join server page #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myleshorton merged 1 commit into from
Feb 6, 2026
Merged

Add navigation from tray directly to the join server page #8451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/features/system_tray/provider/system_tray_notifier.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ class SystemTrayNotifier extends _$SystemTrayNotifier with TrayListener {
onClick: (_) => toggleVPN(),
),
MenuItem.separator(),
MenuItem(
key: 'join_server',
label: 'join_server'.i18n,
onClick: (_) {
// Open Lantern and navigate to the join server page
ref.read(windowProvider.notifier).open(focus: true);
appRouter.push(JoinPrivateServer());
},
Comment on lines +68 to +75
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tray menu label uses the i18n key join_server ("Join Server"), but other entry points to this flow use "Join Private Server" / "Join a Private Server" (join_private_server / join_a_private_server). Consider switching the tray label to the same i18n key for consistent wording (the route being opened is JoinPrivateServer).

Copilot uses AI. Check for mistakes.
),
MenuItem(
key: 'show_window',
label: 'show'.i18n,
Expand All @@ -88,6 +97,7 @@ class SystemTrayNotifier extends _$SystemTrayNotifier with TrayListener {
await trayManager.setContextMenu(menu);
trayManager.setIcon(_trayIconPath(isConnected),
isTemplate: Platform.isMacOS);
trayManager.setToolTip('app_name'.i18n);
}

String _trayIconPath(bool connected) {
Expand Down
Loading