Add navigation from tray directly to the join server page#8451
Merged
myleshorton merged 1 commit intomainfrom Feb 6, 2026
Merged
Add navigation from tray directly to the join server page#8451myleshorton merged 1 commit intomainfrom
myleshorton merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new system tray entry point to open the app directly on the “Join Private Server” screen, and improves tray usability by setting a localized tooltip.
Changes:
- Added a
join_servertray menu item that opens the main window and navigates toJoinPrivateServer. - Set the tray icon tooltip to the localized application name (
'app_name'.i18n).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+68
to
+75
| MenuItem( | ||
| key: 'join_server', | ||
| label: 'join_server'.i18n, | ||
| onClick: (_) { | ||
| // Open Lantern and navigate to the join server page | ||
| ref.read(windowProvider.notifier).open(focus: true); | ||
| appRouter.push(JoinPrivateServer()); | ||
| }, |
There was a problem hiding this comment.
Tray menu label uses the i18n key join_server ("Join Server"), but other entry points to this flow use "Join Private Server" / "Join a Private Server" (join_private_server / join_a_private_server). Consider switching the tray label to the same i18n key for consistent wording (the route being opened is JoinPrivateServer).
atavism
pushed a commit
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the system tray functionality by adding a new menu item for joining a private server and improving the tray icon's user experience. The most important changes are:
System Tray Menu Enhancements:
join_servermenu item to the system tray, which opens the main window and navigates the user to the join private server page when clicked.User Experience Improvements: