Release/v2.0.0-alpha.1

.gitignore

@@ -1,2 +1,4 @@
 node_modules
-build
+build
+*.tgz
+*.log

.npmignore

@@ -0,0 +1,13 @@
+*
+!.eslintignore
+!.eslintrc
+!binding.gyp
+!getdns.js
+!LICENSE
+!package.json
+!README.md
+!resources/logo/*.png
+!samples/example-raw.js
+!src/*.cpp
+!src/*.h
+!test/*.js

getdns.js

@@ -33,8 +33,17 @@ const getdns = require("bindings")("getdns");
 module.exports = getdns.constants;
 
 // Wrap context creation.
-module.exports.createContext = function(...args) {
-    const ctx = new getdns.Context(...args);
+module.exports.createContext = function(options) {
+    if (arguments.length > 1) {
+        // NOTE: duplicated in getdns.js and GNContext.cpp.
+        // TODO: use new getdns.Context(...args) when not supporting node.js v4 anymore.
+        const tooManyArgumentsTypeError = new TypeError("Too many arguments.");
+        tooManyArgumentsTypeError.code = getdns.constants.RETURN_INVALID_PARAMETER;
+
+        throw tooManyArgumentsTypeError;
+    }
+
+    const ctx = new getdns.Context(options);
     const oldDestroyFunc = ctx.destroy;
     let destroyed = false;
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "getdns",
-  "version": "1.0.0",
+  "version": "2.0.0-alpha.1",
   "description": "getdns bindings for Node.js. getdns is a modern asynchronous DNS API. It implements DNS entry points from a design developed and vetted by application developers, in an API specification.",
   "main": "getdns.js",
   "keywords": [
@@ -43,7 +43,7 @@
   },
   "scripts": {
     "install": "npm run --silent rebuild",
-    "postinstall": "npm run --silent rebuild",
+    "postinstall": "npm run --silent rebuild && npm run --silent test",
     "clean": "node-gyp clean",
     "build": "node-gyp configure build",
     "rebuild": "node-gyp rebuild",

src/GNContext.cpp

@@ -768,6 +768,8 @@ NAN_METHOD(GNContext::Destroy) {
 NAN_METHOD(GNContext::New) {
     if (info.IsConstructCall()) {
         if (info.Length() > 1) {
+            // NOTE: duplicated in getdns.js and GNContext.cpp.
+            // TODO: use new getdns.Context(...args) when not supporting node.js v4 anymore.
             Local<Value> typeError = makeTypeErrorWithCode("Too many arguments.", GETDNS_RETURN_INVALID_PARAMETER);
             return Nan::ThrowError(typeError);
         }

test/bad-dns-warning.js

@@ -78,7 +78,7 @@ describe("BADDNS", () => {
                         getdns.BAD_DNS_CNAME_RETURNED_FOR_OTHER_TYPE,
                     ];
 
-                    return badDnsValus.includes(badDns);
+                    return badDnsValus.indexOf(badDns) !== -1;
                 });
                 expect(badDnsReplies.length).to.be(reply.bad_dns.length);
             });

test/shared.js

@@ -31,9 +31,8 @@ const expect = require("expect.js");
 const segfaultHandler = require("segfault-handler");
 
 const initialize = () => {
+    // Dump segfault stacktraces both to the console and to a file.
     const segfaultDumpFilename = "crash.log";
-
-// Dump segfault stacktraces both to the console and to a file.
     segfaultHandler.registerHandler(segfaultDumpFilename);
 };