Skip to content

Conversation

@joelpurra
Copy link
Collaborator

I'd be happy if this version got some testing across platforms!

Try this to install it to your (test) project:

npm install --save "git+https://github.com/joelpurra/getdns-node.git#release/v2.0.0-alpha.1"
* ce3fc4d (joelpurra/release/v2.0.0-alpha.1) v2.0.0-alpha.1
* 423596b (getdnsapi/develop) Clean up tests, add more
* 0710db8 Add more transaction cancellation tests
* b2a3dd7 Add test to check for the right type/number of arguments to createContext()
* bc33c4e Check createContext() for too many arguments
* b3d0f35 Don't allow context options which do not exist on the context (hopefully as setters)
* 0c5de0f Check that context options have the right type and are set properly
* 9f8e250 Allow running tests in serial, as opposed to the parallel default
* 7a20116 Add contributors to readme
* 357bcf4 Remove node v0.10, v0.12 and iojs from travis builds
* 37b9b8b Update requirements in readme
* 0b6a315 Update build/test instructions, mention git flow init command
* fcfb1cd Use npm for build scripts
* fb6f60e Add link directly to upstream getdns/getdns.h and getdns/getdns_extra.h
* 4e65ccb Update sample response output in readme, links to examples
* 6419046 Add arguments to example-raw.js
* 1951e16 Disable color output for non-TTY in sample-console-pretty
* 514f515 Split up test to multiple files
* 341f1b9 Expand concurrent tests
* ad34e63 Use the default recursive mode rather than stub mode where tests don't fail
* 31821f7 Clean up tests
* da43a41 Use mocha-parallel-tests to speed up test runs
* e9dc09d Add missing getdns constants
* 4902862 Fix conversion of IPv4/IPv6 bindata to strings
* caf72d0 Fix dnssec_return_only_secure mention in readme; it's an extension

@joelpurra
Copy link
Collaborator Author

After some javascript feature/version fixes for node.js v4, the build passes -- but with an intermittent SIGSEGV error. This could very well map to any of the "ordinary" issues, such as timeouts. It seems as if the SIGSEGV happens (is displayed) after all the tests are done though, so it seems only indirectly related to them. (Or shutting down the node.js process after the tests does something odd.)

  • As the errors were intermittent and happen on the build server, it's not easy to reproduce.
  • If the error is due to results of some DNS lookup, it might mean that it only happens every few hundred or thousand lookups.
  • The segfault handler is active, and should put a dump in crash.log, in case someone can reproduce the crash.
  • Most likely the problem is in src/GNContext.cpp.
  • Note that there are changes in GNContext::~GNContext().
  • I'm not experienced in C++, so eyeballs would help!

If it's hard to reproduce/debug/report, I'm inclined to let it pass to get v2.0.0-alpha.1 out the door. Let's give it a few days first.

@joelpurra joelpurra changed the title Release/v2.0.0 alpha.1 Release/v2.0.0-alpha.1 Apr 3, 2017
@joelpurra joelpurra changed the base branch from master to develop April 3, 2017 06:04
@joelpurra joelpurra merged commit d7a07a3 into getdnsapi:develop Apr 5, 2017
@joelpurra
Copy link
Collaborator Author

This version has now been released to npm as getdns-node v2.0.0-alpha.1! See also the v2.0.0-alpha.1
tag
in git.

Installation:

npm install --save getdns

Next time I'll try to tag the release to npm with npm publish --tag=next so as not to have it be the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant