Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase isolated app balance #710

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 25, 2024

Closes #479

Adds ability to "Increase" the balance of an isolated app in 3 places (new isolated app connection, isolated app connection page, friends & family app)

Also renames the db service as this only had app-related functionality, and cleaned up some previous TODOs there.

On the UI it's just called "Increase". The user is warned that they must actually have enough real balance on their channels to make payments, as the isolated app balance could be larger than their channel balance.

TODO:

  • Test Wails mode
  • Create a new issue for followup improvement - to allow setting choosing a balance before creating apps (UI change only)

image

image

image

image

image

image

@bumi
Copy link
Contributor

bumi commented Sep 25, 2024

Is it possible to set this also similar to the budget also when creating the connection?

print paper money using it

I don't think your comparison his correct here. there is no "paper money'. It allows a connection to spend a certain amount. and maybe the admin allows a connection to spend the same money that the admin already promised to another connection.

But we're not building a bank or a financial system here, so I think you should not try to compare it to that.
It's an app to manage sats and that allows the owner of the sats to give some people the permission to spend those sats.
comparing a wife-husband relationship to a broken financial system or to some bank is imo flawed. We need to think what the user wants and what makes sense for that setup.

@rolznz
Copy link
Contributor Author

rolznz commented Sep 25, 2024

@bumi

Is it possible to set this also similar to the budget also when creating the connection?

I think we can. Internally it'd still need to create and pay an invoice after the app is created, but the UX flow might be better that way, true.

@bumi
Copy link
Contributor

bumi commented Oct 7, 2024

I think we can. Internally it'd still need to create and pay an invoice after the app is created, but the UX flow might be better that way, true.

we just have to make sure that our API endpoints stay simple and unversal and don't get bloated with such things.

@rolznz
Copy link
Contributor Author

rolznz commented Oct 7, 2024

we just have to make sure that our API endpoints stay simple and unversal and don't get bloated with such things.

Update: maybe we leave this until a second iteration for now.

@rolznz rolznz merged commit 731d248 into master Oct 28, 2024
9 checks passed
@rolznz rolznz deleted the feat/increase-isolated-balance branch October 28, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage isolated connection
2 participants