New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: app child key derived from wallet master key #736

Merged

rolznz merged 55 commits into master from feat/wallet-child-key-per-connection

Nov 7, 2024

Contributor

frnandu commented Oct 14, 2024 •

edited by rolznz

Loading

fixes #724
fixes #744


          feat(appwalletKey): add GetBIP32ChildKey

83de003

frnandu changed the title ~~app child key derived from wallet master key~~ [WiP] app child key derived from wallet master key

frnandu added 2 commits

October 14, 2024 17:29


          feat: fix interface

546322c


          feat: adding subscription WiP

8cbe566

rolznz reviewed

View reviewed changes

db/migrations/202410141503_wallet_child_idx.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

db/models.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/event_handler.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/event_handler.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/event_handler.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

nip47/notifications/nip47_notifier.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/start.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/start.go Outdated Show resolved Hide resolved


          feat: handle nostr subscriptions for lifecycle of apps

853beed

frnandu requested review from rolznz, bumi and reneaaron

October 18, 2024 22:33

frnandu added 6 commits

October 19, 2024 00:35


          Delete .idea/.gitignore

8cb135d


          Delete .idea/hub.iml

616a69b


          Delete .idea/modules.xml

55113ce


          Delete .idea/vcs.xml

78c2faa


          fix: remove unnecessary

e7ae82c


          fix: missing handling legacy app

dc404dd

rolznz reviewed

View reviewed changes

db/db_service.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

db/db_service.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

db/models.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

db/db_service.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

db/migrations/202410141503_wallet_child_pubkey.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/keys/keys.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/keys/keys.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/start.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/start.go Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

service/start.go Outdated Show resolved Hide resolved

frnandu added 8 commits

October 31, 2024 12:20


          fix: add legacy tests

932a9fb


          fix: move fetching of Nip47 event info to deleteAppConsumer

17c9c0b


          fix: fixed arguments

8127fea


          fix: use require instead of assert

7cff2a7


          Merge branch 'master' into feat/wallet-child-key-per-connection

339d420


          fix: adapt GetAppWalletKey to use DeriveKey with path 1'

606c33b


          fix: for backends that don't use a mnemonic, create appKey from nostr…

877509e

…SecretKey


          fix: cleanup eventPublisher Subscribers when relay reconnects

c47d923

im-adithya reviewed

View reviewed changes

service/keys/keys.go Outdated Show resolved Hide resolved

api/api.go

		@@ -80,7 +80,8 @@ func (api api) CreateApp(createAppRequest CreateAppRequest) (*CreateAppRespons
		expiresAt,

Member

im-adithya Nov 5, 2024

Follow-up issue: The expiresAt, scopes checks above are to be shifted to CreateApp method in apps_service and UpdateApp, GetApp, ListApps, TopupIsolatedApp methods need to be added there. I think we can also GetAppByPubkey directly in those methods so we don't have to call it separately in http_service and wails_service

Contributor

rolznz Nov 6, 2024

@im-adithya could you create an issue and link some code?

nip47/event_handler.go Show resolved Hide resolved

nip47/publish_nip47_info.go Show resolved Hide resolved

nip47/nip47_service.go Show resolved Hide resolved

service/keys/keys.go Show resolved Hide resolved

service/delete_app_consumer.go Show resolved Hide resolved

frnandu added 3 commits

November 6, 2024 17:21


          fix: bip32.FirstHardenedChild + appID

7bfd140


          fix: remove unused env vars

ce4c5cf


          fix: generate new mnemonic if empty

8c1ef4b

Member

im-adithya commented Nov 6, 2024

For some reason, if you do a fresh install (complete setup and go to Home page), the app isn't quitting on doing Ctrl+C

frnandu added 2 commits

November 6, 2024 23:43


          fix: add tests.CreateTestServiceWithMnemonic to fix TestEncryptedBackup

aea59f0


          fix: handle both relay and main ctx Done

78f59bc

Contributor Author

frnandu commented Nov 6, 2024 •

edited

Loading

For some reason, if you do a fresh install (complete setup and go to Home page), the app isn't quitting on doing Ctrl+C

Oh sorry, I broke that when trying to handle relay.Context().Done() when there is no subscription on legacy app wallet pubKey.
Don't have much experience with go contexts, but I think it should be fixed now by using a select and handle both <-ctx.Done() and <-relay.Context().Done()
Let me know if you have a chance to re-test this and confirm it is working both doing Ctrl-C and by restarting a local test relay (should reconnect and re-subscribe each app).
Thanks for catching this!

Contributor

rolznz commented Nov 7, 2024

For some reason, if you do a fresh install (complete setup and go to Home page), the app isn't quitting on doing Ctrl+C

Oh sorry, I broke that when trying to handle relay.Context().Done() when there is no subscription on legacy app wallet pubKey. Don't have much experience with go contexts, but I think it should be fixed now by using a select and handle both <-ctx.Done() and <-relay.Context().Done() Let me know if you have a chance to re-test this and confirm it is working both doing Ctrl-C and by restarting a local test relay (should reconnect and re-subscribe each app). Thanks for catching this!

@frnandu that sounds like a good solution. Thanks @im-adithya !

rolznz added 6 commits

November 7, 2024 12:07


          Merge branch 'master' into feat/wallet-child-key-per-connection

b322f4c


          chore: add keys tests

b4bf53f


          chore: add extra assertions to keys test

caed3b3


          chore: log when legacy app subscription is created

2b14d3c


          chore: remove unnecessary break

dc54213


          chore: add log when relay is successfully connected

0be7e32

rolznz approved these changes

View reviewed changes

Contributor

rolznz left a comment

tACK

im-adithya reviewed

View reviewed changes

service/start.go Show resolved Hide resolved


          fix: only auto-start node if it has been started before

287607d

rolznz merged commit 5fdc803 into master

8 of 9 checks passed

rolznz deleted the feat/wallet-child-key-per-connection branch

November 7, 2024 12:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet