Add user group attributes #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taba90
commented
Jun 6, 2022
taba90
commented
- add user groups attributes management to geostore.
- add migration scripts and update schema creation scripts.
offtherailz
requested changes
Oct 6, 2022
| @@ -0,0 +1,16 @@ | |||
| create table gs_user_group_attribute ( | |||
There was a problem hiding this comment.
need to remame these files and update to 1.10.0 (or whatever).
14 tasks
taba90
force-pushed
the
add-user-group-attributes
branch
from
8e2da9e
to
1da6f05
Compare
|
thanks for the review @offtherailz feedback applied. |
offtherailz
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
LGTM. Maybe before to merge we need to set the proper migration guidelines to update the database.
I have this PR for UI geosolutions-it/MapStore2#7875
I'll do another PR tomorrow to update migration guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.